feat: add flat layout toggle for song tables - #2282
Open
adambenhassen wants to merge 1 commit into
Open
Conversation
One click swaps a song table between its default columns and a flat layout (index, title, artist, album, date added, duration) with no artwork. Reaching that layout previously meant toggling eight columns by hand in the config modal, per list. Switching back restores the list's factory defaults rather than a hardcoded song order, so album detail keeps its track number column and playlist detail keeps its reorder handle. Compact row height drops from 40px to 32px; 40px left too much dead space for a single line of text.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
I don't think it makes sense adding a toggle for a predefined column set. Also, 40px was chosen because it is the minimum height at which we can fit the two rows for the I think what you're looking for would actually be user-defined table configuration presets which you can quickly switch between. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One click swaps a song table between its default columns and a flat layout (index, title, artist, album, date added, duration) with no artwork. Reaching that layout previously meant toggling eight columns by hand in the config modal, per list.
Switching back restores the list's factory defaults rather than a hardcoded song order, so album detail keeps its track number column and playlist detail keeps its reorder handle.
Compact row height drops from 40px to 32px; 40px left too much dead space for a single line of text.
This should bring the layout closer to how the classic layout of Spotify looks like right now: